Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo discovery for private/non-existing repos #334

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Nov 16, 2023

Closes #333

Make sure that audb does not raise a backend error when looking for databases on different backends, including ones where no permissions are given or that do not exist. For the later you might argue that it is ok to raise an error, but on Artifactory we cannot differentiate between having no access rights and non-existing repos. As we usually share the same config file for all users, it seems more important to me to not fail in the case of missing access rights.

The pull request first adds a test that fails for the current main branch, and changes the code afterwards to no longer raise an error.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #334 (6ae47ae) into main (ba8c0d9) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
Files Coverage Δ
audb/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw force-pushed the fix-private-repos branch 2 times, most recently from 4271b3f to 32c5c62 Compare November 16, 2023 11:54
@hagenw
Copy link
Member Author

hagenw commented Nov 16, 2023

@ChristianGeng as this issue is quite urgent and affects most users, I will skip the review for it in order to make a new release as soon as possible.

@hagenw hagenw merged commit 58a1572 into main Nov 16, 2023
9 checks passed
@hagenw hagenw deleted the fix-private-repos branch November 16, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading a database can fail if a user don't have access to one of the defined repositories
1 participant