[WIP] General tweaks to configuration and such to bring codebase up to date #391
Conversation
mvastola
force-pushed
the
housekeeping
branch
3 times, most recently
from
aea8d7d
to
d9b0bb8
Compare
Remove activerecord, etc from gemspec (seems to not be standard to include supported ORMs, etc there). Disable fast-finish for now to make debugging all the compatibility issues easier. Also added script to generate list of excludes in `.travis.yml`. (Since we're supporting so many versions right now, there are a ton)
| @@ -4,3 +4,5 @@ | |||
| pkg | |||
| Gemfile.lock | |||
| coverage | |||
| /.idea | |||
There was a problem hiding this comment.
Not everybody uses Jetbrains editors.
While this does not hurt. its bad practice to clutter projects with local env settings.
best to put that in the home folder of the dev
$ grep ign ~/.gitconfig
excludesfile = ~/.gitignore_global
my two cents on the topic
| @@ -0,0 +1,38 @@ | |||
| os: linux | |||
There was a problem hiding this comment.
travis no longer offer supports for opensource project.
need to migrate this to Github Actions, or something else...
| @@ -0,0 +1,32 @@ | |||
|
|
|||
| SUPPORTED_RAILS_VERSIONS = %w[3.0 3.1 3.2 4.0 4.1 4.2 5.0 5.1 5.2 6.0 6.1] | |||
There was a problem hiding this comment.
probably a good time to trash everything below 5.2
|
|
||
| gem 'sqlite3' | ||
|
|
||
| if RUBY_VERSION < '2.1.0' |
| s.files = `git ls-files`.split("\n") | ||
| s.test_files = `git ls-files -- test/*`.split("\n") | ||
| s.files = `git ls-files`.split("\n") | ||
| s.test_files = `git ls-files -- test/*`.split("\n") | ||
|
|
||
| s.required_ruby_version = '>= 2.0.0' |
There was a problem hiding this comment.
2.6 should be minimum now.
2.5 if you want to push it, but there are no good reason to still support anything below.
| YAML.dump(travis_config, f) | ||
| end | ||
|
|
||
| printf "Done. (%d excludes and %d allowed failures)\n", excludes.size, failables.size |
There was a problem hiding this comment.
that must have been fun to write.
I now prefer using includes instead of excludes. Travis also supports it.
but here is a Github Actions example
https://github.com/payrollhero/webhook_system/blob/master/.github/workflows/ci.yml
Signed-off-by: Mike Vastola <[email protected]>
Work in progress. Expecting many build failures.