Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block ERC721 transfers #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rotcivegaf
Copy link
Contributor

@rotcivegaf rotcivegaf commented May 16, 2023

Block the transfers of ERC721:

  • transferFrom(address,address,uint256)
  • safeTransferFrom(address,address,uint256)
  • safeTransferFrom(address,address,uint256,bytes)

Use _transfer instead of transferFrom

And add transfer test

@TimDaub
Copy link
Member

TimDaub commented May 16, 2023

Hey thanks for your work here, I really appreciate it. I originally planned to make a bigger change on the main branch but then focused on something else. Anyways, my original plan had included using https://github.com/attestate/ERC5192 as this would then also encapsulate the blocking and its details in that standard. The plan was also to make the changes to the specification in that regard. Would you be up to do that? I‘m happy to assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants