This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Disable service replicas with development mode flag #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remain consistent with other services, this adds a development mode flag to reduce the number of replicas to 1.
wilkers-steve
force-pushed
the
dev_mode_updates
branch
from
fb6eefa to
388a249
Compare
wilkers-steve
changed the title
intlabs
reviewed
Mar 16, 2017
| compute_replicas: 1 | ||
| replicas: | ||
| control: 1 | ||
| compute: 1 |
There was a problem hiding this comment.
Is compute used? If not can we remove it?
|
yup, i'll let you close it out. i think that if we just stick with a developer focused config-override on the client side, rather than with debt in the form of conditionals we'll be in a lot better shape (imo, and as we've discussed collectively). |
|
Absolutely agreed. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable service replicas with development mode flag in all charts
To remain consistent with other services, this adds a development
mode flag to reduce the number of replicas to 1.
What is the purpose of this pull request?: Disables replicas for a service when development flag is set to
enabledWhat issue does this pull request address?: Partially addresses #258
Notes for reviewers to consider:
Specific reviewers for pull request: