STM32 GPIO driver fixes #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
approved these changes
Oct 26, 2023
Also use TUPLE_SIZE(x) macro rather than hardcoded values. Signed-off-by: Davide Bettio <[email protected]>
IS_NULL_PTR is already `UNLIKELY(x == NULL)`, no need to add UNLIKELY also here. Signed-off-by: Davide Bettio <[email protected]>
`globalcontext_make_atom` returns an atom term, so let's just use it when needed. Signed-off-by: Davide Bettio <[email protected]>
MUTABLE_LIST_FOR_EACH is useful only when changes are made to the list while iterating over it, otherwise LIST_FOR_EACH is the right choice. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
stm32_gpio_driver-fixes
branch
from
00573dc to
05e98e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes few issues introduced with #836.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later