Add missing unicode module #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w31/add-missing-unicode-module
branch
from
2bfcc40
to
628607a
Compare
bettio
requested changes
Aug 6, 2023
pguyot
force-pushed
the
w31/add-missing-unicode-module
branch
from
628607a
to
729a11a
Compare
bettio
requested changes
Aug 9, 2023
pguyot
force-pushed
the
w31/add-missing-unicode-module
branch
from
729a11a
to
052dbda
Compare
pguyot
force-pushed
the
w31/add-missing-unicode-module
branch
from
257870b
to
c26fe9c
Compare
bettio
requested changes
Aug 10, 2023
Implement `unicode:characters_to_list/1,2` and `unicode:characters_to_binary/1,2,3` using new `interop_iolist_fold`. This fixes `io_lib:format/2` with `t` modifier. Rename `interop_iolist_fold` to `interop_chardata_fold` because it really processes `iodata` and now `chardata` as it works for unicode. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w31/add-missing-unicode-module
branch
from
c26fe9c
to
ca8d8de
Compare
bettio
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
unicode:characters_to_list/1,2andunicode:characters_to_binary/1,2,3using newinterop_iolist_fold.This fixes
io_lib:format/2withtmodifier.Rename
interop_iolist_foldtointerop_chardata_foldbecause it really processesiodataand nowchardataas it works for unicode.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later