Enable SMP for emscripten #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
approved these changes
Jul 20, 2023
|
CI doesn’t pass for node. |
pguyot
force-pushed
the
w29/emscripten-enable-smp
branch
from
b619ec3
to
ddce32c
Compare
Actually, it was flappy. |
Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w29/emscripten-enable-smp
branch
from
ddce32c
to
16c98ac
Compare
|
Tests pass locally and CI passed three times in a row after rebasing and fixing conflicts, so let's mark this ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later