Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: add esp:partition_list/0 function #679

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

bettio
Copy link
Collaborator

@bettio bettio commented Jul 11, 2023

Add function for listing all available partitions.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@bettio bettio added platform:esp32 ESP32 platform specific lib:eavmlib Erlang AtomVM library and removed lib:eavmlib Erlang AtomVM library labels Jul 11, 2023
@bettio bettio changed the title ESP32: add esp:partition_list/0 function ESP32: add esp:partition_list/0 function Jul 11, 2023
@pguyot
Copy link
Collaborator

pguyot commented Jul 12, 2023

Do you think we could get a esp32 qemu test for this?

libs/eavmlib/src/esp.erl Outdated Show resolved Hide resolved
src/platforms/esp32/components/avm_sys/platform_nifs.c Outdated Show resolved Hide resolved
src/platforms/esp32/components/avm_sys/platform_nifs.c Outdated Show resolved Hide resolved
@bettio bettio force-pushed the esp-partition-list branch 7 times, most recently from d164055 to 93c85b4 Compare July 18, 2023 22:11
Add function for listing all available partitions.

Starting from this change ESP_PARTITION_TYPE_ANY is required, hence
esp-idf < v4.4 cannot be supported.

Signed-off-by: Davide Bettio <[email protected]>
This test will compare the partition list against a fixture created from
`esp32/test/partitions.csv`.

Signed-off-by: Davide Bettio <[email protected]>
@bettio
Copy link
Collaborator Author

bettio commented Jul 19, 2023

Do you think we could get a esp32 qemu test for this?

We have a qemu test now.

@bettio bettio requested a review from fadushin July 19, 2023 13:42
@bettio bettio merged commit f9aaac6 into atomvm:master Jul 20, 2023
74 of 75 checks passed
@bettio bettio deleted the esp-partition-list branch July 20, 2023 12:47
bettio added a commit that referenced this pull request Jul 27, 2023
Completely remove idf < 4.4

ESP-IDF < v4.4 wasn't already supported since #679, however it was still
mentioned in documentation and in few other places.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:esp32 ESP32 platform specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants