Fix broken ESP32 builds due to name atom redefinition
#1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge of commit 3fdcd0d breaks esp32 builds due to a redefinition of the `name` atom, that was added to libAtomVM/defaultatoms.{c,h}. These changes fix the problem by removing the `name` atom from the esp32 platform_defaultatoms since this atom is now global. Signed-off-by: Winford <[email protected]>
|
This fixes the broken esp32 builds, but there is still a bug in the CI related to the memory check tests. |
bettio
approved these changes
Dec 24, 2024
bettio
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge of commit 3fdcd0d breaks esp32 builds due to a redefinition of the
nameatom, that was added to libAtomVM/defaultatoms.{c,h}. These changes fix the problem by removing thenameatom from the esp32 platform_defaultatoms since this atom is now global.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later