Updates to ESP32 GPIO driver to match other MCU platforms #1408
+174
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need to remove RISING_ATOM_INDEX et al in platform_defaultatoms.h ? |
This is done in commit bede918 |
…river.c Moves the atoms only needed by the GPIO driver out of ESP32 platform_defaultatoms.h and into the gpio driver, where they are created as needed at runtime. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
esp32_gpio_spec
branch
from
587b4d4 to
aca3489
Compare
|
My mistake, you are correct! Those changes should have been included in the commit I mentioned, but were not added. Correction has been pushed. |
UncleGrumpy
force-pushed
the
esp32_gpio_spec
branch
from
aca3489 to
fa94ff3
Compare
UncleGrumpy
force-pushed
the
esp32_gpio_spec
branch
from
fa94ff3 to
c4c5343
Compare
Changes error returns to match the spec and ofther platforms. Nifs now raise any errors, and port
function errors return `{error, Reason}`.
Updates gpio.erl to reflect the correct returns, and make it more clear that errors for nifs will be
raised.
Closes atomvm#894
Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
esp32_gpio_spec
branch
from
c4c5343 to
24fdbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move the GPIO specific atoms out of the ESP32 platform default atoms (created at boot) into the GPIO driver where they are only created as needed.
Breaking changes update the error returns to match the spec. Nifs raise
Error, and port functions return{error, Reason}when errors are encountered.Closes #894
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later