Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encoded refs in external terms #1363

Merged

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Nov 7, 2024

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch from 6b39040 to 598f8c3 Compare November 24, 2024 23:17
@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch from 598f8c3 to 069cfb9 Compare December 21, 2024 21:09
@pguyot pguyot changed the base branch from main to feature/distributed-erlang December 21, 2024 21:22
@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch 2 times, most recently from 911c138 to 0294574 Compare December 21, 2024 21:51
@pguyot pguyot marked this pull request as ready for review December 21, 2024 21:51
src/libAtomVM/nifs.c Outdated Show resolved Hide resolved
@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch from 0294574 to 01a3cd1 Compare December 21, 2024 22:38
src/libAtomVM/term.h Outdated Show resolved Hide resolved
src/libAtomVM/term.c Show resolved Hide resolved
src/libAtomVM/term.c Outdated Show resolved Hide resolved
src/libAtomVM/term.c Outdated Show resolved Hide resolved
src/libAtomVM/term.h Outdated Show resolved Hide resolved
@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch 4 times, most recently from edc2413 to 4c3b5ca Compare December 22, 2024 22:40
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seem good, just a minor note that might increase readability (or maybe not).
Meanwhile I'll make sure the CI will be green.

src/libAtomVM/externalterm.c Outdated Show resolved Hide resolved
@pguyot
Copy link
Collaborator Author

pguyot commented Dec 23, 2024

Everything seem good, just a minor note that might increase readability (or maybe not).

Meanwhile I'll make sure the CI will be green.

I'm pretty sure there is a test that fails and needs to be fixed.

@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch from 4c3b5ca to fe45624 Compare December 23, 2024 06:44
Also add partial support for external refs.
Also fix list representation of local refs as a ref with two words,
matching external term encoding.
Also fix order of pids to match OTP.

Signed-off-by: Paul Guyot <[email protected]>
@pguyot pguyot force-pushed the w45/encode_and_decode_refs branch from fe45624 to bf1d1c0 Compare December 23, 2024 20:59
@bettio bettio merged commit 642a280 into atomvm:feature/distributed-erlang Dec 24, 2024
101 checks passed
@pguyot pguyot deleted the w45/encode_and_decode_refs branch December 24, 2024 05:47
bettio added a commit that referenced this pull request Dec 24, 2024
Introduce ports (local and external)

Continuation of #1363

Native ports are now represented as ports, and can be encoded in binaries.
External ports are also supported. String representation of ports matches
OTP's.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants