Add support for term serialize (as external term) to buffer #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
external-term-serialize
branch
2 times, most recently
from
f2f8b26
to
938dbe8
Compare
Make functions for writing a term using external term format to a buffer accessible, so there is no need to use a binary. externalterm_serialize_term(_raw) and externalterm_compute_external_size(_raw) functions can be useful when using external term format in NIFs or port drivers. Before this change `externalterm_to_binary` was the only available function, but was forcing using a binary term as output. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
external-term-serialize
branch
from
938dbe8
to
d53fab5
Compare
bettio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there was a
externalterm_to_termfunction that was taking a buffer and returning a term, there wasn't the exact opposite, since it was returning a binary.These new functions can be useful for any NIF or function that manipulates just the buffer and not the whole binary.
This will allow to implement later both support for compressed format or to optimize/cleanup the
erlang:term_to_binaryNIF.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later