-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken uart
module
#1307
Fix broken uart
module
#1307
Conversation
I noticed that there was another problem on my device which prevents me from processing UART. So this statement might be false. Actually I read the old code twice and cannot find problems. It seems I have to reword the commit comment and CHANGELOG.md to state that my commit is just a refactor. |
Thank you for this! We just discovered this bug and were discussing it in our Telegram chat, which I would encourage you to join: The core developers and many community members are frequently active there, and we would welcome having you join our conversations. |
Thank you for info about Telegram community. I already joined, but I seldom use Telegram, so I didn't noticed this PR is mentioned there. If there is someone who wants to talk to me there, please don't hesitate to mention me. I'm there with the same username (@aiotter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of changes are still required. I think it can be good after that.
Let us know if the final PR works on real hardware as expected so we can merge it.
Thanks for all you did so far.
Thank you for your review. The current code is already tested, in other words, the commits in the PR are cherry-picked from the branch I build AtomVM from and I'm using it in my daily development. I'll check your review, correct the code ,reword the commit comment, test it on my device and let you know then. |
Use newer APIs to make it easier to read Signed-off-by: Yuto Oguchi <[email protected]>
Nif `uart_driver` can only parse uppercased peripheral name Signed-off-by: Yuto Oguchi <[email protected]>
Tested and it worked. Now it's ready to be merged. |
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
uart
module for ESP32 is broken. This PR fixes it.uart:open/1,2
takesuart0
,uart1
oruart2
asperipheral
option. However, Nif takes either one ofUART0
,UART1
orUART2
. This PR corrects the behaviour ofuart:open
to match that of Nif.uart
module does not send a reply parsable byport:call
, which stops the process from executing further codes. This PR fixes that by usingport_send_reply
function.