Fix unicode bogus oom #1280
Merged
Fix unicode bogus oom #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
fix-unicode-bogus-oom
branch
5 times, most recently
from
3570db3
to
e13c743
Compare
pguyot
reviewed
Sep 23, 2024
tests/test.c
Outdated
| // NULL when size is 0. | ||
| // This is useful to find debugging or finding some kind of issues. | ||
| #ifdef FORCE_MALLOC_ZERO_RETURNS_NULL | ||
| // required for memalign |
There was a problem hiding this comment.
AFAIK, memalign is a deprecated linuxism. Standard function is posix_memalign.
bettio
force-pushed
the
fix-unicode-bogus-oom
branch
from
e13c743
to
a179915
Compare
Quoting `man malloc`: "If size is 0, then malloc() returns either NULL, or a unique pointer value that can later be successfully passed to free()." Platforms such as esp-idf prefers NULL in that case. So `IS_NULL_PTR` may fail in situations such as when dealing with `malloc(size)` when size is 0 (due to a 0 length binary, leading to out of memory when doing `unicode:characters_to_list(<<>>)` on ESP32 but not on other platforms. Signed-off-by: Davide Bettio <[email protected]>
Allow to override malloc/calloc functions to provide a version that behaves like esp-idf one, when malloc(0) is called. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
fix-unicode-bogus-oom
branch
from
a179915
to
7f72885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode:characters_to_list(<<>>)was failing with (a bogus) out_of_memory error.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later