otp_net.c: use EAI_OVERFLOW when it is defined

[barracuda156]

Closes: #1254

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

[pguyot]

We probably should use cmake macro check_symbol_exists instead of C #ifdef which doesn't catch enums.

In src/platforms/generic_unix/lib/CMakeLists.txt, we check for EAI_BADHINTS only. Is EAI_OVERFLOW the only undefined symbol on your platform? Could you please confirm the darwin version you are using?

[barracuda156]

We probably should use cmake macro check_symbol_exists instead of C #ifdef which doesn't catch enums.

In src/platforms/generic_unix/lib/CMakeLists.txt, we check for EAI_BADHINTS only. Is EAI_OVERFLOW the only undefined symbol on your platform? Could you please confirm the darwin version you are using?

@pguyot I actually found this old issue now: OpenSMTPD/OpenSMTPD#1246
Specifically, see: OpenSMTPD/OpenSMTPD#1246 (comment)

There the solution was OpenSMTPD/OpenSMTPD@276e064

P. S. My original fix was borrowed from mojca/luasocket@4189bd5

[barracuda156]

@pguyot And yes, that was the only problematic define for me. I am on 10.6 ppc, which is somewhat in between 10.5.8 and 10.6.8 in terms of SDK features.

[barracuda156]

@pguyot I have updated the patch here.

[bettio]

Sorry for the late review, if you don't mind it would be great having this in release-0.6 branch, so we can include it with next v0.6.6 release.