Improve unicode atom support #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
improve-unicode-atom-support
branch
4 times, most recently
from
72b2d4e to
1f13543
Compare
bettio
force-pushed
the
improve-unicode-atom-support
branch
2 times, most recently
from
ef249bc to
87f1da5
Compare
pguyot
requested changes
Feb 18, 2024
bettio
force-pushed
the
improve-unicode-atom-support
branch
3 times, most recently
from
af78db0 to
6598e4e
Compare
bettio
force-pushed
the
improve-unicode-atom-support
branch
from
6598e4e to
ee9e546
Compare
fadushin
reviewed
Feb 21, 2024
fadushin
reviewed
Feb 22, 2024
fadushin
reviewed
Feb 22, 2024
fadushin
reviewed
Feb 22, 2024
bettio
force-pushed
the
improve-unicode-atom-support
branch
from
ee9e546 to
cd3e205
Compare
fadushin
reviewed
Feb 23, 2024
Allow also utf8 and unicode encodings in addition to latin1. Signed-off-by: Davide Bettio <[email protected]>
Both functions have been introduced with OTP23 and they default to utf8. Signed-off-by: Davide Bettio <[email protected]>
Test conversion from binary/list to unicode atoms and viceversa, and a number of other corner cases. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
improve-unicode-atom-support
branch
from
cd3e205 to
708f994
Compare
|
Merging after short telegram discussion, collected Paul's feedback on #1060. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later