-
Notifications
You must be signed in to change notification settings - Fork 365
Conversation
@50Wliu The code and test coverage look good, but I adjusted the wording a bit and got rid of the H1. I want to make it clear that a workspace is always associated with a project, but sometimes that project is empty. You can add folders to it, or you can reopen a previous project. I played with the second button being "Reopen A Previous Project" but it felt a little long. What do you think? Happy to iterate on this. |
Looks great to me! Thanks :) |
Thanks for doing this. It's a really nice UX improvement. |
Not really a huge fan of this, especially when opening single files. |
I completely agree with this request to include an option to disable this feature. I have created this RFE. |
Requirements
Description of the Change
The Tree View isn't created if no projects are open in a window, limiting discoverability of how to add a project. To make it easier to add projects, this PR now always shows the Tree View. If no projects are open, the Tree View prompts to add projects:
Alternate Designs
None.
Benefits
Easier to add projects directly through the Tree View.
Possible Drawbacks
Tree View will now appear, even when no projects are open.
Applicable Issues
Refs #1313. There currently is no way to "promote" a single file to a full project without manually selecting its project root.
Closes #1312
Fixes #68
Todo
updateRoots
wasn't called twice in a row on startup, which sometimes led to two of the add-project-views being added to the DOM.