Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update README and Appveyor #793

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update README and Appveyor #793

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2016

  • Include shift-lowercase.
  • Add commands and keybindings

@winstliu
Copy link
Contributor

I have an abandoned branch at e968a4a that you might want to take a look at for some additional changes to the README.

@ghost
Copy link
Author

ghost commented Oct 14, 2016

@50Wliu I saw your branch. What do you think if I change it like this:

Find and Replace package

macOS Build Status Windows Build Status Dependency Status

Find and replace in the current buffer or across the entire project in Atom.

Find in buffer

Usage

You can open find and replace for each individual buffer by navigating to Find > Find in Buffer or find and replace for an entire project by navigating to Find > Find in Project. To close, press Find in Buffer or Find in Project again, respectively.

Once opened, the first text box is used to find phrases that can also be replaced by content in the second text box. Replace All will replace all instances of the first text box's text. If using find in project, there is also an additional text box that allows you to specify which directories/files are to be searched.

There are also multiple options available while using find and replace:

  • .* - Use Regex
  • Aa - Match case
  • " - Only in selection (not available for find in project)
  • \b - Whole word (not available for find in project)

Want to learn more? Check out the Using Atom: Find and Replace section in the Atom flight manual.

Commands and Keybindings

Command Description Keybinding (Linux) Keybinding (macOS) Keybinding (Windows)
project-find:show Show the project find and replace dialog ctrl-shift-f cmd-shift-f ctrl-shift-f
project-find:confirm Find the next occurence of the phrase cmd-enter ctrl-enter
project-find:toggle-regex-option Toggle the "regex" option cmd-alt-/ ctrl-alt-/
project-find:toggle-case-option Toggle the "match case" option cmd-alt-c ctrl-alt-c
project-find:toggle-whole-word-option Toggle the "whold word" option cmd-alt-w ctrl-alt-w
project-find:replace-all Replace all occurences of the phrase ctrl-enter cmd-enter ctrl-enter
find-and-replace:show Show the buffer find and replace dialog ctrl-f cmd-f ctrl-f
find-and-replace:show-replace Toggle the buffer find and replace dialog and focuses the replace text box ctrl-alt-f cmd-alt-f ctrl-alt-f
find-and-replace:confirm Find the next occurence of the phrase cmd-enter ctrl-enter
find-and-replace:toggle-regex-option Toggle the "regex" option cmd-alt-/ ctrl-alt-/
find-and-replace:toggle-case-option Toggle the "match case" option cmd-alt-c ctrl-alt-c
find-and-replace:toggle-selection-option Toggle the "obly in selection" option cmd-alt-s ctrl-alt-s
find-and-replace:toggle-whole-word-option Toggle the "whold word" option cmd-alt-w ctrl-alt-s
find-and-replace:find-all Find all occurences of the pharase ctrl-enter cmd-enter ctrl-enter
find-and-replace:find-next Find the next occurence of the phrase f3 cmd-g f3
find-and-replace:find-previous Find the previous occurence of the phrase shift-f3 cmd-shift-g shift-f3
find-and-replace:find-next-selected Find the next occurence of the phrase selected ctrl-f3 cmd-f3 ctrl-f3
find-and-replace:find-previous-selected Find the previous occurence of the phrase selected ctrl-shift-f3 cmd-shift-f3 ctrl-shift-f3
find-and-replace:select-all Select all occurences of the phrase alt-f3 cmd-ctrl-g alt-f3
find-and-replace:select-next Select the next occurence of the phrase ctrl-d cmd-d ctrl-d
find-and-replace:select-undo Undo the last selection ctrl-u cmd-u ctrl-u
find-and-replace:select-skip Skip the current selection ctrl-k ctrl-d cmd-k cmd-u ctrl-k ctrl-u
find-and-replace:focus-next Focus the next text box in the find and replace dialog tab tab tab
find-and-replace:focus-previous Focus the previous text box in the find and replace dialog shift-tab shift-tab shift-tab
find-and-replace:replace-all Replace all occurences of the phrase ctrl-enter cmd-enter ctrl-enter

Contributing

Always feel free to help out! Whether it's filing bugs and feature requests or working on some of the open issues, Atom's contributing guide will help get you started while the guide for contributing to packages has some extra information.

License

MIT License. See the license for more details.

@ghost
Copy link
Author

ghost commented Oct 14, 2016

I think should use new screenshot but I don't have a good picture, can you help me? I saw your branch and README.md in Settings View

@maxbrunsfeld
Copy link
Contributor

Our standard practice with key binding names is to display both shift and the uppercase version of the letter.

@ghost
Copy link
Author

ghost commented Oct 29, 2016

I think should use shift+lowercase beacause it it is more realistic.

@maxbrunsfeld
Copy link
Contributor

I think should use shift+lowercase beacause it it is more realistic.

I can see the rationale for always using lowercase, but for now we need to remain consistent with the rest of Atom.

@ghost
Copy link
Author

ghost commented Nov 3, 2016

@maxbrunsfeld you want to keep it as original?

@maxbrunsfeld
Copy link
Contributor

You've made some really nice improvements, and I can see that the keybindings were already written strangely (omitting the shift modifier). I'd love to merge this. Would you mind tweaking the keybindings to use the cmd-shift-F style?

@ghost
Copy link
Author

ghost commented Nov 6, 2016

@maxbrunsfeld Sorry but it means I should revert find-and-replace.cson.

@maxbrunsfeld
Copy link
Contributor

Could you change keybindings so that they include both the shift and the capital letter?

@ghost
Copy link
Author

ghost commented Nov 8, 2016

They included both the shift and the capital letter!

@winstliu
Copy link
Contributor

winstliu commented Nov 8, 2016

You just broke the keybindings in 6081ead - please revert it. What Max is asking for is for you to change the keybindings in the README (I believe).

@ghost
Copy link
Author

ghost commented Nov 8, 2016

@50Wliu It means I should replace all shift-lowerCase with shift-upperCase in the README?

@winstliu
Copy link
Contributor

winstliu commented Nov 8, 2016

cmd-shift-f -> cmd-shift-F in both the keybindings and the readme.

@ghost
Copy link
Author

ghost commented Dec 14, 2016

Ping! I finished my job. @50Wliu @maxbrunsfeld.

@ghost ghost changed the title Update commands and keybinding Update README and Appveyor Feb 15, 2017
@ghost
Copy link
Author

ghost commented Feb 15, 2017

I think should use shift-lowerCase and can see at atom/atom#13007

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants