-
Notifications
You must be signed in to change notification settings - Fork 196
Update README and Appveyor #793
base: master
Are you sure you want to change the base?
Conversation
ghost
commented
Oct 13, 2016
•
edited by ghost
Loading
edited by ghost
- Include shift-lowercase.
- Add commands and keybindings
I have an abandoned branch at e968a4a that you might want to take a look at for some additional changes to the README. |
@50Wliu I saw your branch. What do you think if I change it like this: Find and Replace packageFind and replace in the current buffer or across the entire project in Atom. UsageYou can open find and replace for each individual buffer by navigating to Find > Find in Buffer or find and replace for an entire project by navigating to Find > Find in Project. To close, press Find in Buffer or Find in Project again, respectively. Once opened, the first text box is used to find phrases that can also be replaced by content in the second text box. There are also multiple options available while using find and replace:
Want to learn more? Check out the Using Atom: Find and Replace section in the Atom flight manual. Commands and Keybindings
ContributingAlways feel free to help out! Whether it's filing bugs and feature requests or working on some of the open issues, Atom's contributing guide will help get you started while the guide for contributing to packages has some extra information. LicenseMIT License. See the license for more details. |
I think should use new screenshot but I don't have a good picture, can you help me? I saw your branch and README.md in Settings View |
[ci skip]
Our standard practice with key binding names is to display both |
I think should use shift+lowercase beacause it it is more realistic. |
I can see the rationale for always using lowercase, but for now we need to remain consistent with the rest of Atom. |
@maxbrunsfeld you want to keep it as original? |
You've made some really nice improvements, and I can see that the keybindings were already written strangely (omitting the |
@maxbrunsfeld Sorry but it means I should revert |
Could you change keybindings so that they include both the |
They included both the |
You just broke the keybindings in 6081ead - please revert it. What Max is asking for is for you to change the keybindings in the README (I believe). |
@50Wliu It means I should replace all |
|
[ci skip]
Ping! I finished my job. @50Wliu @maxbrunsfeld. |
I think should use shift-lowerCase and can see at atom/atom#13007 |