-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint 9 + compatibility check #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiv
requested changes
Oct 7, 2024
mvarendorff2
force-pushed
the
feat/compatibility-check
branch
from
October 7, 2024 09:54
252d69c
to
f279523
Compare
lockfile
reiv
force-pushed
the
feat/compatibility-check
branch
from
October 8, 2024 07:58
f279523
to
e197703
Compare
reiv
approved these changes
Oct 8, 2024
mvarendorff2
commented
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a (poorly organized) handful of things:
Note to reviewer
Functionality of the compatibility project and CI can be seen on the Actions for commit 72cfff6 which had the compatibility layer removed for testing. All ESLint 8 jobs completed while the ESLint 9 ones failed.