Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 9 + compatibility check #335

Merged
merged 22 commits into from
Oct 8, 2024
Merged

ESLint 9 + compatibility check #335

merged 22 commits into from
Oct 8, 2024

Conversation

mvarendorff2
Copy link
Member

@mvarendorff2 mvarendorff2 commented Oct 7, 2024

This PR includes a (poorly organized) handful of things:

  • Support for ESLint 9 (breaking change)
  • Monorepo structure to support a compatibility checking project
  • A compatibility checking project + a GH Action to validate new packages working seamlessly in a project with Node 18/20/22 + ESLint 8/9
  • Setup of Renovate to respect the GH Action for automerge

Note to reviewer

Functionality of the compatibility project and CI can be seen on the Actions for commit 72cfff6 which had the compatibility layer removed for testing. All ESLint 8 jobs completed while the ESLint 9 ones failed.

@mvarendorff2 mvarendorff2 marked this pull request as ready for review October 7, 2024 09:33
.github/workflows/check-compatibility.yml Outdated Show resolved Hide resolved
.github/workflows/check-compatibility.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@reiv reiv merged commit 82a92d0 into main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants