Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added useHover and usePopover in utils #483

Merged
merged 6 commits into from
Aug 29, 2023
Merged

feat: added useHover and usePopover in utils #483

merged 6 commits into from
Aug 29, 2023

Conversation

KentCpu
Copy link
Contributor

@KentCpu KentCpu commented Aug 21, 2023

No description provided.

@KentCpu KentCpu requested a review from Nelfimov August 21, 2023 18:38
@KentCpu KentCpu self-assigned this Aug 21, 2023
@KentCpu
Copy link
Contributor Author

KentCpu commented Aug 21, 2023

Задача #468

Изменения:

  • Добавил хук useHover
  • Добавил хук usePopover

Nelfimov
Nelfimov requested changes Aug 24, 2023
View reviewed changes
utils/use-popover/package.json Show resolved Hide resolved
utils/use-popover/package.json Show resolved Hide resolved
@KentCpu KentCpu requested a review from Nelfimov August 26, 2023 16:17
@KentCpu
Copy link
Contributor Author

KentCpu commented Aug 26, 2023

@Nelfimov

  1. Нужно ли в use-hover добавить peerDependencies ? В dependies уже есть пакет react-laag, у которого в peerDependies уже есть react и react-dom. По идее, они должны подтянутся автоматически или нет ?
  2. В задаче была упомянута довольно ситуативная утилита , стоит ли ее добавить ?

@Nelfimov
Copy link
Member

Нужно ли в use-hover добавить peerDependencies ? В dependies уже есть пакет react-laag, у которого в peerDependies уже есть react и react-dom. По идее, они должны подтянутся автоматически или нет ?

Нет.

В задаче была упомянута довольно ситуативная утилита , стоит ли ее добавить ?

Можно.

@TorinAsakura
Copy link
Member

Конфликт

@TorinAsakura TorinAsakura merged commit 23f14eb into master Aug 29, 2023
2 checks passed
@TorinAsakura TorinAsakura deleted the feat/utils branch August 29, 2023 12:02
@Nelfimov Nelfimov mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nelfimov Nelfimov Nelfimov approved these changes

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees

@KentCpu KentCpu

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KentCpu @Nelfimov @TorinAsakura