refactor: change name and usage props in cards & rm unnecessary comments

atls-academy · Aug 1, 2023 · 9a8f11d · 9a8f11d
1 parent 4905606
commit 9a8f11d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/landing/fragments/landing-courses/src/cards/cards.component.tsx b/landing/fragments/landing-courses/src/cards/cards.component.tsx
@@ -35,7 +35,7 @@ export const Cards = () => {
             widthCategory={{ _: 80, standard: 104, ultra: 148 }}
             сategory={intl.formatMessage({ id: 'courses.card.education' })}
             gap={{ _: 104, standard: 214, wide: 356, ultra: 222 }}
-            waves
+            image='/waves.png'
             widthContent={{ _: 303, standard: 694, ultra: 945 }}
             title={intl.formatMessage({ id: 'courses.card.frontend-engineer' })}
             description={intl.formatMessage({
@@ -47,7 +47,7 @@ export const Cards = () => {
             widthCategory={{ _: 87, standard: 112, ultra: 160 }}
             сategory={intl.formatMessage({ id: 'courses.card.mini-cours' })}
             gap={{ _: 49, standard: 56, wide: 356, ultra: 222 }}
-            waves
+            image='/waves.png'
             widthContent={{ _: 303, standard: 694, ultra: 945 }}
             title={intl.formatMessage({ id: 'courses.card.basics-development' })}
             description={intl.formatMessage({

diff --git a/ui/card/src/card.component.tsx b/ui/card/src/card.component.tsx
@@ -15,8 +15,6 @@ export const Card: FC<CardProps> = ({ ...props }) => {
   const [hover, hoverProps] = useHover()
 
   return (
-    // <Background backgroundColor='waves' backgroundPosition='500px 100px' backgroundRepeat='no-repeat' display={{_:'none',standard:'none',wide:'flex',ultra:'flex'}} width='100%'>
-
     <Box
       width='100%'
       {...hoverProps}
@@ -25,9 +23,9 @@ export const Card: FC<CardProps> = ({ ...props }) => {
       boxShadow={hover ? 'normalBlurDarkPurple' : ''}
       position='relative'
     >
-      {props.waves ? (
+      {props.image ? (
         <Image
-          src='/waves.png'
+          src={props.image}
           position='absolute'
           right={34}
           top={40}
@@ -59,7 +57,6 @@ export const Card: FC<CardProps> = ({ ...props }) => {
 
             <Layout flexBasis={{ _: 8, standard: 12, ultra: 18 }} />
           </Box>
-
           <Layout flexBasis={props.gap} />
           <Box flexDirection='column' maxWidth={props.widthContent}>
             <Box>
@@ -82,6 +79,5 @@ export const Card: FC<CardProps> = ({ ...props }) => {
         <Layout flexBasis={[16, 40]} />
       </Background>
     </Box>
-    // </Background>
   )
 }
diff --git a/ui/card/src/card.interfaces.ts b/ui/card/src/card.interfaces.ts
@@ -2,7 +2,7 @@ export interface CardProps {
   widthCategory?: object | number | number[]
   сategory?: string
   gap?: object | number | number[]
-  waves?: boolean
+  image?: string
   widthContent?: object | number | number[]
   title?: string
   description?: string

diff --git a/ui/link/src/link.styles.tsx b/ui/link/src/link.styles.tsx
@@ -3,8 +3,4 @@ import { createBaseStyles } from '@atls-ui-parts/link'
 
 import { Text }             from '@ui/text'
 
-export const BaseLink = styled(Text.withComponent('a'))<{ active: boolean }>(createBaseStyles(), ({
-  active,
-}) => ({
-  color: active ? 'blue' : 'black',
-}))
+export const BaseLink = styled(Text.withComponent('a'))(createBaseStyles())