Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dedicated Synchrony ingress #883

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

bianchi2
Copy link
Collaborator

@bianchi2 bianchi2 commented Sep 27, 2024

Currently, synchrony path is hardcoded in the ingress which make it impossible to deploy 2 instances of Synchrony using the same hostname but different paths. For example, it's not possible to deploy the following in one cluster:

https://my.confluence.com/instance1
https://my.confluence.com/synchrony-instance1

https://my.confluence.com/instance2
https://my.confluence.com/synchrony-instance2

While it's possible to define Confluence contextPath it's not possible to do so for Synchrony. This PR makes it possible to create a dedicated ingress for Synchrony where it's possible to use rewrite path annotations. Sadly, redefining Synchrony contextPath results in Synchrony not being able to start. With this change it'll be possible to define synchony path in the ingress as path: /synchrony1(/|$)(.*) and add nginx.ingress.kubernetes.io/rewrite-target: /synchrony/$2 annotation. This way requests to synchrony1 will go to Synchrony service on /synchrony path.

If synchrony.ingress.path is defined, we'll update system property passed to Confluence JVM accordingly.

Checklist

  • I have added unit tests
  • I have applied the change to all applicable products
  • The E2E test has passed (use e2e label)

@bianchi2 bianchi2 added the e2e label Sep 27, 2024
@bianchi2 bianchi2 merged commit 57c4ed9 into main Oct 1, 2024
14 checks passed
@bianchi2 bianchi2 deleted the custom-synchrony-ingress-path branch October 1, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants