Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secretList in additionalCertificates #874

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fix secretList in additionalCertificates #874

merged 5 commits into from
Sep 9, 2024

Conversation

bianchi2
Copy link
Collaborator

@bianchi2 bianchi2 commented Sep 5, 2024 •
edited
Loading

It wasn't actually working due to missing:

  • jvm arg in the ConfigMap
  • /var/ssl runtime volume in the main container

Adding those + more unit tests + KinD tests (single secret config is also tested with Synchrony)

Checklist

  • I have added unit tests
  • I have applied the change to all applicable products
  • The E2E test has passed (use e2e label)

@bianchi2 bianchi2 added the e2e label Sep 5, 2024
@bianchi2 bianchi2 merged commit b042c16 into main Sep 9, 2024
3 checks passed
@bianchi2 bianchi2 deleted the additional-secret-list branch September 9, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzha645 yzha645 yzha645 approved these changes

@nanux nanux Awaiting requested review from nanux nanux is a code owner

Assignees
No one assigned
Labels
e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bianchi2 @yzha645