Improvements in the partition code after PR feedback #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
previously approved these changes
Oct 21, 2024
| inputValueDef: GraphQLInputValueDefinition, | ||
| context: NadelFieldPartitionContext, | ||
| ): String? { | ||
| return null |
There was a problem hiding this comment.
Should this have a default? doesn't seem right
I think the noop version below should hardcode null, but the user should be otherwise forced to add an impl given this is the only function in this interface
There was a problem hiding this comment.
Yep makes sense 👍
gnawf
previously approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of @gnawf 's suggestions are addressed here. More PRs will come to address the remaining ones and also @temaEmelyan 's suggestion about the
Payloadinterface 👍