Add VCS aware file change event querying #96
Merged
+1,185
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
changed the title
yamadapc
commented
Sep 29, 2024
There was a problem hiding this comment.
We don't need to support this
tomgasson
reviewed
Sep 29, 2024
| .arg("--deleted") | ||
| .arg("--modified") | ||
| .arg("--others") | ||
| .arg("-z") // We separate rows by \0 to avoid issues with newlines |
There was a problem hiding this comment.
If you are able to distinguish CI builds (which won't have a working tree changes) then you can shortcut a bunch of time spent here.
|
I'll remove the yarn v1 parser - https://gist.github.com/yamadapc/285bc0614027aadf25fd22154dae1538 |
mattcompiles
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prototype of VCS aware change lists queries.
It adds a new filesystem implementation which uses a rust implementation of git diffing / yarn lock/state reading to get the list of changed files.
There is a
README.mdexplaining details including how to roll-out / next steps. As it is, this branch does not consume the event lists returned by VCS, as I'd like to measure the accuracy of the changes.Additionally, an example binary is provided which can be used to list changes.