Change fallback behaviour for __MCOND and fix dependency for runtime #142
+275
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need a safe rollout when
globalThis.__MCONDis not defined (if we mess something up on the control branch of the rollout). We also have an issue where some dependencies don't get loaded correctly when prod mode is on.Changes
Two major changes here:
globalThis.__MCONDexists when configured, so we can have a safe rollout when feature flag is disabledI also added a new integration test and fixed some tests not using the correct data. This can probably allow some refactoring in the style of the new test. Dev mode is broken so I skip the test I fixed (as it's now red).
Checklist