Remove core circular dependencies

[MonicaOlejniczak]

Motivation

There are multiple circular dependencies to @atlaspack/core that have existed for sometime and prevent us from utilising TypeScript references.

graph LR;
    core --> cache --> core;
    core --> fs --> core;
    fs --> workers;
    workers --> core;
    package_manager --> core --> package_manager;

Loading

Changes

• Add @atlaspack/build-cache package to form a new leaf package instead of @atlaspack/core
• Move the build cache, serialisation and deserialisation functions to this new package and rename appropriate references
• Replace @atlaspack/core peer dependency with a regular @atlaspack/build-cache dependency, as this reduces complexity during the installation process and products will resolve to a single copy of atlaspack anyway
• Remove process.browser handling from the worker to remove the circular dependency. This is only used in repl and theoretically should work (or be made to work), but unfortunately repl is currently an extremely broken state and needs several changes to repair it.
• Fix some broken repl references

The new dependency graph for the relevant sections is now as follows.

graph LR;
    core --> cache --> build_cache;
    core --> build_cache;
    core --> package_manager;
    core --> fs --> build_cache;
    fs --> workers;
    package_manager --> build_cache;
    workers --> build_cache;

Loading

Checklist

• Existing or new tests cover this change

[alshdavid]

Amazing work 👏