improve Static_ strong types

atk4 · Jan 11, 2025 · 87a10f3 · 87a10f3
1 parent afd31ee
commit 87a10f3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Persistence/Static_.php b/src/Persistence/Static_.php
@@ -17,10 +17,10 @@
 class Static_ extends Array_
 {
     /** @var string This will be the title field for the model. */
-    public $titleFieldForModel;
+    public ?string $titleFieldForModel = null;
 
     /** @var array<string, array<mixed>> Populate the following fields for the model. */
-    public $fieldsForModel = [];
+    public array $fieldsForModel;
 
     /**
      * @param array<int|string, mixed> $data
@@ -88,7 +88,7 @@ public function __construct(array $data = [])
             }
 
             // if title is not set, use first key
-            if (!$this->titleFieldForModel) {
+            if ($this->titleFieldForModel === null) {
                 if (is_int($k)) {
                     $keyOverride[$k] = 'name';
                     $this->titleFieldForModel = 'name';
@@ -162,7 +162,7 @@ public function add(Model $model, array $defaults = []): void
      */
     protected function addMissingFieldsToModel(Model $model): void
     {
-        if ($this->titleFieldForModel) {
+        if ($this->titleFieldForModel !== null) {
             $model->titleField = $this->titleFieldForModel;
         }