Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README installation instructions #128

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated README installation instructions #128

wants to merge 4 commits into from

Conversation

anshukla
Copy link
Member

@anshukla anshukla commented Jun 1, 2013

The installation instructions now reflect the exact process needed to set up acorn-player from a fresh install. The changes include:

  1. Specifying that only Node v0.8.16 has been tested to work and v0.10.4 is confirmed unsupported.
  2. Including instructions to symlink in Closure.jar and Grunt.js
  3. How to initialize closure git submodule
  4. How to run local version of Grunt because npm install installs Grunt into node_modules

I just re-installed acorn-player using the above changes and everything works!

@jbenet
Copy link
Member

jbenet commented Jun 2, 2013

Awesome! Thanks!

LGTM. Ready to merge except for the grunt path comment above.

Is this not fixed by installing the right versions of grunt/grunt-cli? (on top of the right version of node >.<. we should really just support latest node).

we might still want to break out the closure submodule entirely, as discussed in #120.

@anshukla
Copy link
Member Author

anshukla commented Jun 3, 2013

Just found: nvm. Seems like a much better way to handle installing the right version of Node without all the steps to get brew to work.

@jbenet
Copy link
Member

jbenet commented Jun 6, 2013

Ah, nice find!

I think, though, that we should drop requirements, not add them. I.e. we should just upgrade our project to use latest node and latest grunt.

@jbenet
Copy link
Member

jbenet commented Jun 6, 2013

@ali01 any idea what this requires?

@jbenet
Copy link
Member

jbenet commented Jun 17, 2013

Just wrote https://github.com/athenalabs/acorn-player-examples/ with new grunt, with uglify, and without closure.

@jbenet
Copy link
Member

jbenet commented Jul 25, 2013

Just redid buildsys to use a Makefile. Remove closure/grunt mentions and good to merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants