Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make it a monorepo with the design system #638

Merged
merged 50 commits into from
Jun 15, 2023

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Jun 2, 2023

Description

It adds Turborepo to the project and makes it a monorepo with two apps: studio and design-system.

Related issue(s)

See also #637

Blocked by

#651

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit b001f9b
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/648891392d841a0008b00689
😎 Deploy Preview https://deploy-preview-638--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fmvilas fmvilas linked an issue Jun 2, 2023 that may be closed by this pull request
3 tasks
@fmvilas fmvilas removed a link to an issue Jun 2, 2023
3 tasks
@fmvilas fmvilas requested review from Amzani and KhudaDad414 June 2, 2023 22:57
@fmvilas
Copy link
Member Author

fmvilas commented Jun 3, 2023

I just need to figure out how we're gonna make the automatic releases work. The current GitHub actions are not ready for monorepos. For instance, I'd not like to release a new version of the design-system every time there's a new version of Studio.

@fmvilas
Copy link
Member Author

fmvilas commented Jun 3, 2023

@KhudaDad414 maybe you know how we could handle this? I found this package but not sure if it's helpful.

feat: add extra line(ui)

Update if-nodejs-release.yml

feat: add line

feat: add line both

Update if-nodejs-release.yml

Update if-nodejs-release.yml

fix: remove line

add test

fix: remove line

fix: test

Update if-nodejs-release.yml

feat: add new line

Update if-nodejs-release.yml

fix: remove line

Create test-test.yml

Empty Commit

Update test-test.yml

Empty Commit

Update test-test.yml

Empty Commit

Update test-test.yml

Empty Commit

Update test-test.yml

Empty Commit

Update test-test.yml

Empty Commit

Empty Commit

Update if-nodejs-release.yml

fix: Empty Commit

fix: Empty Commit

Update if-nodejs-release.yml

fix: Empty Commit

Update if-nodejs-release.yml

fix: Empty Commit

Update if-nodejs-release.yml

fix: Empty Commit

Update if-nodejs-release.yml

fix: Empty Commit

fix: Empty Commit

fix: new line in ui

fix: remove extra line(ui)

feat: new line(studio)

feat: added 1 to readme(both)

bump package

Update if-nodejs-version-bump.yml

fix: remove extra lines(studio)

Update if-nodejs-version-bump.yml
@KhudaDad414
Copy link
Member

@fmvilas I have opened a PR against this branch and it should resolve the automatic release issue. fmvilas#1

@fmvilas fmvilas changed the title feat: make it a monorepo with the design system chore: make it a monorepo with the design system Jun 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmvilas
Copy link
Member Author

fmvilas commented Jun 14, 2023

@KhudaDad414 what do you think will happen after I merge? 🤣 Shall I? 😝

@KhudaDad414
Copy link
Member

@fmvilas are the studio tests passing for you? 🤔

@fmvilas
Copy link
Member Author

fmvilas commented Jun 14, 2023

They are. For me and for CI, apparently. Lots of warnings though. Aren't they passing for you?

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 773bf82 into asyncapi:master Jun 15, 2023
@fmvilas fmvilas deleted the monorepo-with-design-system branch June 15, 2023 14:12
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version ui-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version ui-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants