-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make it a monorepo with the design system #638
chore: make it a monorepo with the design system #638
Conversation
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I just need to figure out how we're gonna make the automatic releases work. The current GitHub actions are not ready for monorepos. For instance, I'd not like to release a new version of the design-system every time there's a new version of Studio. |
@KhudaDad414 maybe you know how we could handle this? I found this package but not sure if it's helpful. |
feat: add extra line(ui) Update if-nodejs-release.yml feat: add line feat: add line both Update if-nodejs-release.yml Update if-nodejs-release.yml fix: remove line add test fix: remove line fix: test Update if-nodejs-release.yml feat: add new line Update if-nodejs-release.yml fix: remove line Create test-test.yml Empty Commit Update test-test.yml Empty Commit Update test-test.yml Empty Commit Update test-test.yml Empty Commit Update test-test.yml Empty Commit Update test-test.yml Empty Commit Empty Commit Update if-nodejs-release.yml fix: Empty Commit fix: Empty Commit Update if-nodejs-release.yml fix: Empty Commit Update if-nodejs-release.yml fix: Empty Commit Update if-nodejs-release.yml fix: Empty Commit Update if-nodejs-release.yml fix: Empty Commit fix: Empty Commit fix: new line in ui fix: remove extra line(ui) feat: new line(studio) feat: added 1 to readme(both) bump package Update if-nodejs-version-bump.yml fix: remove extra lines(studio) Update if-nodejs-version-bump.yml
feat: use monorepo release process
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@KhudaDad414 what do you think will happen after I merge? 🤣 Shall I? 😝 |
@fmvilas are the studio tests passing for you? 🤔 |
They are. For me and for CI, apparently. Lots of warnings though. Aren't they passing for you? |
/rtm |
🎉 This PR is included in version ui-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version design-system-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version ui-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version design-system-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
It adds Turborepo to the project and makes it a monorepo with two apps: studio and design-system.
Related issue(s)
See also #637
Blocked by
#651