feat: enable to mount local spec for docker container #433
Conversation
rikuson
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
@magicmatatjahu do you mind having a look? |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
fmvilas
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@rikuson there are errors in your code. Would you mind having a look? Apologies for the delay in the review 🙏 |
|
@rikuson do you need some help with this? |
|
OK, I'll take a look. |
|
/au |
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@KhudaDad414 @fmvilas I fixed! |
|
Sorry, it seems got broken after I merged master branch. I'll fix it. |
|
@KhudaDad414 @fmvilas Done. |
|
@rikuson @KhudaDad414 Sonarcloud is complaining about |
apps/studio/docker-compose.yaml
Outdated
There was a problem hiding this comment.
Now building docker image shows error below.
$ docker-compose up
...
=> ERROR [builder 6/6] RUN turbo prune --scope=@asyncapi/studio --docker
Turbo error: could not resolve workspaces: We did not find a package manager specified in your root package.json. Please set the "packageManager" property in your root package.json (https://nodejs.org/api/packages.html#packagemanager) or run `npx @turbo/codemod add-package-manager` in the root of your monorepo.
I think because it has changed into monorepo.
There was a problem hiding this comment.
It seems not relevant with the issue.
But if I bring Dockerfile and docker-compose.yaml to the root, it works.
What should I do?
There was a problem hiding this comment.
Just move both files to the root @rikuson , the sonarcloud security alert is already on the master branch, we'll try to fix it in an other PR, or just ignore it.
There was a problem hiding this comment.
I moved both files to the root. 👍
rikuson
force-pushed
the
import-from-url
branch
from
6b1fd5b to
50bc64d
Compare
|
SonarCloud Quality Gate failed.
|
|
Hi @rikuson can you take a look at this PR ? Thanks |
|
@rikuson this PR needs some love :) |
|
Sorry, I'm not motivated anymore. |
Description
This is continued from #404 .
@magicmatatjahu
If asyncapi.yaml is removed, it doesn't work on local since dev-server doesn't return 404 code in HTTP header.
dev-server returns html document even if there's no static file.
Can you just ignore
public/docs/asyncapi/asyncapi.yamlandpublic/docs/asyncapi/asyncapi.jsonfor deployment?Related issue(s)
Resolves #403