fix: preventing unmarshal on primitive types #2144
Open
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
lsmacedo
commented
Jan 2, 2025
Comment on lines
+178
to
+180
| if (obj[\\"primitiveArrayTest\\"] !== undefined) { | ||
| instance.primitiveArrayTest = obj[\\"primitiveArrayTest\\"]; | ||
| } |
There was a problem hiding this comment.
Here's evidence that the code doesn't try to call unmarshal anymore for the array of primitive items.
|
lsmacedo
commented
Jan 2, 2025
| @@ -162,13 +175,16 @@ exports[`Marshalling preset should render un/marshal code 1`] = ` | |||
| ? null | |||
| : obj[\\"arrayTest\\"].map((item: any) => NestedTest.unmarshal(item)); | |||
| } | |||
There was a problem hiding this comment.
Here's evidence that for an array of objects, unmarshal is still called.
lsmacedo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's currently a bug on 3.10.0 where calls to unmarshal are made on arrays of primitive type. Here's an example of the generated code:
This PR prevents the issue by adding new checks.
Related Issue
N/A
Checklist
npm run lint).npm run test).Additional Notes
By the way, noticed that version 4.0.0 doesn't include unmarshalling array items, and that might be an issue (at least for my use cases). Just letting you know so you can keep track of this, in case it's not expected.