fix(pydantic): python unwrap properties #2111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modelina canceled.
|
memdal
changed the title
maxplatov
reviewed
Oct 23, 2024
maxplatov
reviewed
Oct 23, 2024
memdal
force-pushed
the
fix-python-unwrap-properties
branch
from
2f8a06b
to
23d2168
Compare
memdal
force-pushed
the
fix-python-unwrap-properties
branch
from
23d2168
to
3b24e63
Compare
|
maxplatov
reviewed
Oct 25, 2024
| @@ -114,7 +117,7 @@ def unwrap_${dictionaryModel?.propertyName}(cls, data): | |||
| .map((value) => `'${value.unconstrainedPropertyName}'`) | |||
| .join(', ')}] | |||
| ${dictionaryModel?.propertyName} = {} | |||
| for obj_key in list(data.keys()): | |||
| for obj_key in cls.list_keys(data): | |||
There was a problem hiding this comment.
I still believe that this code will never called due to condition above
if len(unknown_object_properties) == 0:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pydantic code generation now checks if data is a dict or an object before getting keys in the unwrap functions.
Checklist
npm run lint).npm run test).Additional Notes