-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use channel.address instead of id #582
Conversation
Pull Request Test Coverage Report for Build 6904144969
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Souvikns , can you also make sure that when we receive a message, we pass the channel name to the message when it is created not channel address, since glee will verify the channel name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we receive a message and create the message here:
return new GleeMessage({
payload: packet.payload,
headers,
channel: packet.topic,
})
}
we use the channel address (which is topic) but glee expects to receive the channel id.
I mean we should change this code to create the message with the channel id not channel address here.
If you run the current code with an example, it will fail.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
🎉 This PR is included in version 0.30.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Souvikns you will need to manually update CLI -> https://github.com/asyncapi/cli/blob/master/assets/create-glee-app/templates/tutorial/package.json#L19 as the bumper that we use, is capable to updating just one dependency in given repo, and first on the list that it takes into account is the default one only |
Description
This small fix updates
channel.address()
instead ofchannel.id()
in mqtt.Related issue(s)
Fixes #581