Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set ag cli and nunjucks as deprecated #1331

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

derberg
Copy link
Member

@derberg derberg commented Jan 20, 2025

This PR is built on the shoulders of previous hard work done by @lmgyuan and @Gmin2

It replaces PRs:

It closes #1229 and closes #1255

It also closes #1226 as during hours of discussing deprecation subject we figured it is not a topic we need to solve now but when things will be removed. Also we will probably just rename cli.js to develop.js and that is it.

This PR also closes #1212

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: e683ea8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/generator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

README.md Outdated Show resolved Hide resolved
apps/generator/cli.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member Author

derberg commented Jan 21, 2025

@Florence-Njeri thanks, I see you already applied suggestions automatically - I reviewed, all good, thanks 🍺
@DhairyaMajmudar thanks for quality review, great points

@Florence-Njeri
Copy link
Collaborator

Florence-Njeri commented Jan 22, 2025

Hey @derberg I will take another look this evening

Copy link
Collaborator

@Florence-Njeri Florence-Njeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Gmin2 Gmin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done @derberg

@derberg
Copy link
Member Author

derberg commented Jan 23, 2025

@Gmin2 thanks, tbh it took me like one hour to complete the PR only because of all the hard work you and @lmgyuan did initially. I didn't have to do any research or thinking on hard decisions as we talked it through in details already and I just had to join 2 PRs in one. Thanks!

/rtm

@asyncapi-bot asyncapi-bot merged commit fd5dfd7 into asyncapi:master Jan 23, 2025
13 checks passed
@derberg
Copy link
Member Author

derberg commented Jan 23, 2025

@all-contributors
please add @Gmin2 for bug,code,ideas,doc,review,test
please add @lmgyuan for bug,code,ideas,doc,review,test

Copy link
Contributor

@derberg

I've put up a pull request to add @Gmin2! 🎉

@derberg
Copy link
Member Author

derberg commented Jan 23, 2025

@all-contributors please add @lmgyuan for bug,code,ideas,doc,review,test

Copy link
Contributor

@derberg

I've put up a pull request to add @lmgyuan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
6 participants