-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set ag
cli and nunjucks
as deprecated
#1331
Conversation
🦋 Changeset detectedLatest commit: e683ea8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I added a few suggestions thatwill make the docs more cohesive
Quality Gate passedIssues Measures |
@Florence-Njeri thanks, I see you already applied suggestions automatically - I reviewed, all good, thanks 🍺 |
Hey @derberg I will take another look this evening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done @derberg
@all-contributors |
I've put up a pull request to add @Gmin2! 🎉 |
@all-contributors please add @lmgyuan for bug,code,ideas,doc,review,test |
I've put up a pull request to add @lmgyuan! 🎉 |
This PR is built on the shoulders of previous hard work done by @lmgyuan and @Gmin2
It replaces PRs:
It closes #1229 and closes #1255
It also closes #1226 as during hours of discussing deprecation subject we figured it is not a topic we need to solve now but when things will be removed. Also we will probably just rename
cli.js
todevelop.js
and that is it.This PR also closes #1212