-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing params validation in testFile_md component #1309
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Hey @toffee-k21 you have changed in wrong file. You have to do in 'apps/generator/test/test-templates/react-template/template/test-file.md.js' this file but you have done in autogenerated file 'apps/generator/test/test-templates/react-template/__transpiled/test-file.md.js' In the __transpiled folder there are autogenerated files. |
Hey @ItshMoh, I've moved the file implementation to the correct folder. Let me know if this looks good or if any adjustments are needed. |
const TestFile = ({ asyncapi, params }) => { | ||
return ( | ||
<File name="test-file.md"> | ||
<Text>This is a markdown file for my application.</Text> | ||
<Text>App name is: **{ asyncapi.info().title() }**</Text> | ||
<Text>Version {params.version} running on {params.mode} mode </Text> | ||
</File> | ||
); | ||
} No newline at end of file | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's about using function
syntax as it was used before in place of arrow functions since this will maintain the code consistency of the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented the feature using the 'function' keyword
Quality Gate passedIssues Measures |
Description