Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for var allowed_deserialization_classes #2125

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

pankajastro
Copy link
Contributor

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Happy for this to be merged once tests are passing, @pankajastro !

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (e4222cb) to head (6b8e941).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   90.16%   89.14%   -1.02%     
==========================================
  Files          75       75              
  Lines        4322     4322              
  Branches      539      539              
==========================================
- Hits         3897     3853      -44     
- Misses        325      366      +41     
- Partials      100      103       +3     
Flag Coverage Δ
PythonSDK 89.14% <ø> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro merged commit 02f7a89 into main Mar 6, 2024
33 checks passed
@pankajastro pankajastro deleted the fix_regex branch March 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants