Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging and unpin numpy and cython versions in pyproject.toml #306

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

alicjapolanska
Copy link
Collaborator

Fix issues with path to logging config yaml

Unpin numpy and Cython to ensure numpy 2 compatibility (still relying on packages that need numpy<2 e.g. distrax so keeping it pinned in requirements).

Remove some unused imports

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.65%. Comparing base (6e29129) to head (cafd90e).

Files with missing lines Patch % Lines
harmonic/logs.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   95.65%   95.65%   -0.01%     
==========================================
  Files          14       14              
  Lines        2304     2300       -4     
==========================================
- Hits         2204     2200       -4     
  Misses        100      100              
Flag Coverage Δ
95.65% <89.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@CosmoMatt CosmoMatt merged commit 9726ce2 into main Sep 26, 2024
1 check passed
@CosmoMatt CosmoMatt deleted the logging_update branch September 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants