Use PEP 517 to extract non-static pyproject.toml metadata
#2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/setup-ii
branch
11 times, most recently
from
a5fb6f4 to
c68cf55
Compare
This was referenced Mar 23, 2024
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
c68cf55 to
9da1182
Compare
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
9da1182 to
d45f850
Compare
|
Sorry I'm a little lost in all the changes lately, just want to confirm does this address #2130 as well? or was that addressed previously? |
|
I don't think so, that issue surprises me but I'll look into it separately... |
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
d45f850 to
a12ac81
Compare
zanieb
reviewed
Mar 25, 2024
zanieb
reviewed
Mar 25, 2024
zanieb
reviewed
Mar 25, 2024
| @@ -967,6 +967,87 @@ impl MarkerTree { | |||
| } | |||
| } | |||
|
|
|||
| /// Remove the extras from a marker, returning `None` if the marker tree evaluates to `true`. | |||
There was a problem hiding this comment.
Maybe @BurntSushi should review this marker code.
There was a problem hiding this comment.
Sure, feel free @BurntSushi.
There was a problem hiding this comment.
Messaged with Andrew, I want to build on this branch (but not related to the markers) so I'm going to merge and address any review comments post-merge.
zanieb
reviewed
Mar 25, 2024
zanieb
reviewed
Mar 25, 2024
zanieb
approved these changes
Mar 25, 2024
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
a12ac81 to
18049a8
Compare
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
18049a8 to
3bea576
Compare
charliermarsh
force-pushed
the
charlie/setup-ii
branch
from
3bea576 to
4b2f249
Compare
This was referenced Mar 25, 2024
Closed
BurntSushi
reviewed
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user passes a
pyproject.tomltopip compile(e.g.,uv pip compile pyproject.toml), we extract the requirements from thepyproject.tomldirectly. However... that isn't always possible (as seen in the linked issues). When it's not, we instead need to run the PEP 517 build hooks to identify the metadata.Closes #1624.
Closes #1644.
Test Plan
cargo test