Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate unicode-width to 0.2.0 #13473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 23, 2024

This PR contains the following updates:

Package Type Update Change
unicode-width workspace.dependencies minor 0.1.11 -> 0.2.0

Release Notes

unicode-rs/unicode-width (unicode-width)

v0.1.14

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Sep 23, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 0.2.0
    Updating crates.io index
error: failed to select a version for the requirement `unicode-width = "^0.1"`
candidate versions found which didn't match: 0.2.0
location searched: crates.io index
required by package `annotate-snippets v0.9.2`
    ... which satisfies dependency `annotate-snippets = "^0.9.2"` (locked to 0.9.2) of package `ruff_python_parser v0.0.0 (/tmp/renovate/repos/github/astral-sh/ruff/crates/ruff_python_parser)`
    ... which satisfies path dependency `ruff_python_parser` (locked to 0.0.0) of package `red_knot_python_semantic v0.0.0 (/tmp/renovate/repos/github/astral-sh/ruff/crates/red_knot_python_semantic)`
    ... which satisfies path dependency `red_knot_python_semantic` (locked to 0.0.0) of package `red_knot v0.0.0 (/tmp/renovate/repos/github/astral-sh/ruff/crates/red_knot)`

@renovate renovate bot added the internal An internal refactor or improvement label Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser added the breaking Breaking API change label Sep 23, 2024
@MichaReiser
Copy link
Member

We should hold back on this until the next minor release because some characters now resolve to a different width, which is a breaking change for the formatter and E501.

Hmm, it also seems that we're now blocked on #10832, unless we can use cargo patch.

@MichaReiser MichaReiser added this to the v0.7 milestone Sep 23, 2024
@AlexWaygood AlexWaygood modified the milestones: v0.7, v0.8 Oct 8, 2024
@MichaReiser
Copy link
Member

I reviewed the usages of width to understand if we're affected by the breaking change where \n.width` no returns 1 instead of zero and I think we're good.

Let's ship this with the next minor, just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants