Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override the locale when running bsdtar actions #2044

Merged
merged 7 commits into from
Jan 4, 2025

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Dec 18, 2024

Fixes #2039
Workaround bazel-contrib/bazel-lib#1018


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
    Figma had a repro and confirmed this one-line change fixes it for them.

Copy link

aspect-workflows bot commented Dec 18, 2024

Test

3 test targets passed

Targets
//:npm_link_targets_test [k8-fastbuild]                                  298ms
//npm/private/test:node_modules_test [k8-fastbuild]                      65ms
//npm/private/test:write_npm_translate_lock_bzlmod_0_test [k8-fastbuild] 93ms

Total test execution time was 456ms. 209 tests (98.6%) were fully cached saving 38s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 782ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 138ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 97ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 317ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 362ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

1 test target passed

Targets
//app/a:npm_link_targets_test [k8-fastbuild]                             210ms

Total test execution time was 210ms. 9 tests (90.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

1 test target passed

Targets
//app/a:npm_link_targets_test [k8-fastbuild]                             237ms

Total test execution time was 237ms. 11 tests (91.7%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 263ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 100ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.


Buildifier      Format

@alexeagle alexeagle requested a review from jbedard December 18, 2024 00:43
@alexeagle alexeagle marked this pull request as ready for review December 18, 2024 00:49
Allows users to override the locale, needed for tarballs with filenames not supported by the system locale
npm/private/npm_import.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle merged commit 6b1dc20 into main Jan 4, 2025
94 of 102 checks passed
@alexeagle alexeagle deleted the alexeagle-patch-1 branch January 4, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: package tar extraction fails with unicode characters in paths
2 participants