-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override the locale when running bsdtar actions #2044
Conversation
Test3 test targets passed Targets//:npm_link_targets_test [k8-fastbuild] 298ms //npm/private/test:node_modules_test [k8-fastbuild] 65ms //npm/private/test:write_npm_translate_lock_bzlmod_0_test [k8-fastbuild] 93ms Total test execution time was 456ms. 209 tests (98.6%) were fully cached saving 38s. Teste2e/bzlmodAll tests were cache hits 5 tests (100.0%) were fully cached saving 782ms. Teste2e/gyp_no_install_scriptAll tests were cache hits 2 tests (100.0%) were fully cached saving 138ms. Teste2e/js_image_ociAll tests were cache hits 1 test (100.0%) was fully cached saving 6s. Teste2e/npm_link_packageAll tests were cache hits 3 tests (100.0%) were fully cached saving 555ms. Teste2e/npm_link_package-esmAll tests were cache hits 3 tests (100.0%) were fully cached saving 575ms. Teste2e/npm_translate_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 26ms. Teste2e/npm_translate_lock_emptyAll tests were cache hits 1 test (100.0%) was fully cached saving 26ms. Teste2e/npm_translate_lock_multiAll tests were cache hits 2 tests (100.0%) were fully cached saving 97ms. Teste2e/npm_translate_lock_partial_cloneAll tests were cache hits 1 test (100.0%) was fully cached saving 22ms. Teste2e/npm_translate_lock_replace_packagesAll tests were cache hits 3 tests (100.0%) were fully cached saving 317ms. Teste2e/npm_translate_lock_subdir_patchAll tests were cache hits 1 test (100.0%) was fully cached saving 93ms. Teste2e/npm_translate_package_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 26ms. Teste2e/npm_translate_yarn_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 26ms. Teste2e/package_json_moduleAll tests were cache hits 1 test (100.0%) was fully cached saving 362ms. Teste2e/pnpm_lockfilesAll tests were cache hits 40 tests (100.0%) were fully cached saving 3s. Teste2e/pnpm_workspace1 test target passed Targets//app/a:npm_link_targets_test [k8-fastbuild] 210ms Total test execution time was 210ms. 9 tests (90.0%) were fully cached saving 2s. Teste2e/pnpm_workspace_rerooted1 test target passed Targets//app/a:npm_link_targets_test [k8-fastbuild] 237ms Total test execution time was 237ms. 11 tests (91.7%) were fully cached saving 2s. Teste2e/repo_mappingAll tests were cache hits 2 tests (100.0%) were fully cached saving 276ms. Teste2e/rules_fooAll tests were cache hits 2 tests (100.0%) were fully cached saving 263ms. Teste2e/runfilesAll tests were cache hits 1 test (100.0%) was fully cached saving 100ms. Teste2e/vendored_nodeAll tests were cache hits 1 test (100.0%) was fully cached saving 181ms. Buildifier Format |
9a6d7cd
to
7431fa7
Compare
Allows users to override the locale, needed for tarballs with filenames not supported by the system locale
7431fa7
to
d84a211
Compare
Fixes #2039
Workaround bazel-contrib/bazel-lib#1018
Changes are visible to end-users: no
Test plan
Figma had a repro and confirmed this one-line change fixes it for them.