CMake fixes #191
CMake fixes #191
Conversation
Set needed variable. Fixed unum-cloud/usearch#522.
|
These fixed are really needed. Please merge and publish a new version. |
|
@Spixmaster can look into this later today, thanks! |
CMakeLists.txt
Outdated
| install( | ||
| TARGETS stringzilla_shared | ||
| ARCHIVE | ||
| BUNDLE CXX_MODULES_BMI |
There was a problem hiding this comment.
We don't need CXX BMI here as well, I believe.
There was a problem hiding this comment.
I understand that argument for SimSIMD as it is written in C but StringZilla is a C++ library. I would install everything that is related to C++ for a C++ library.
There was a problem hiding this comment.
Not really, StringZilla in-core is two C99 libraries: header-only and pre-compiled shared lib with dynamic dispatch. There is also a third header-only C++11 wrapper, so we need to install them all with different settings. But this requires a full CMake rewrite and will take much more time.
It's expected with the next major release.
There was a problem hiding this comment.
Yes the CMake files really need a revamp. I would suggestall projects SimSIMD, StringZilla and usearch.
There was a problem hiding this comment.
Still remove CXX_MODULES_BMI?
There was a problem hiding this comment.
Yes, let's remove the BMI for now, and keep the bigger changes for future. If you have broader changes in mind, can you please comment on this PR?
Set needed variable.
Fixed unum-cloud/usearch#522.