Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul: ES6, ESLint, package.json, some smaller fixes #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

flying-sheep
Copy link

@flying-sheep flying-sheep commented Sep 7, 2017

Supersedes #11.

I used a simpler UMD-style function without AMD, because browserify/webpack don’t need that, and ESLint only works with a IIFE.

all commits are rather small, except for the ESLint style thing, so just look at them individually, please.

I also fixed a bug that occurs if e.g. $.fn.dataTable doesn’t exist (only DataTable with “D”)

@ashl1
Copy link
Owner

ashl1 commented Sep 8, 2017

Whoaaa!
I'm planed to move to ES6 in month, but you 'very already done it. Great job!
I'll look at next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants