Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve command incompatibility issue on Windows #86

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

gamjaa
Copy link
Contributor

@gamjaa gamjaa commented Nov 26, 2024

This is a PR for issue #85.

Some commands did not work as intended on Windows, so I made some modifications to the code.

  • mkdir -p can be replaced with mkdir, but it returns an error if the directory already exists.
  • rm -rf can be replaced with rmdir /S /Q
  • On Windows, echo outputs the " characters as-is.

To make the code OS-agnostic, I replaced the commands with os.MkdirAll and os.RemoveAll.

@ashishb
Copy link
Owner

ashishb commented Nov 26, 2024

Please format the code with 'make format'

@gamjaa
Copy link
Contributor Author

gamjaa commented Nov 26, 2024

@ashishb I've fixed the issue and committed the changes. Please review again.

@ashishb ashishb merged commit 4240ff0 into ashishb:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants