build: update eslint & tsconfig (#469)

* build: minimize shared `tsconfig` options

* build: update `eslint` shared conf

* build: add `eslint` to `playwright` & `vitest` confs

* fix: codacy ` @typescript-eslint/no-unsafe-assignment` go away

apps/blog/tsconfig.json

@@ -1,20 +1,9 @@
 {
   "extends": "@ashgw/tsconfig/base.json",
   "compilerOptions": {
-    "lib": ["ES2022", "dom", "dom.iterable"],
-    "jsx": "preserve",
     "baseUrl": ".",
-    "module": "esnext",
-    "target": "ES2022",
     "paths": {
       "~/*": ["./src/*"]
-    },
-    "plugins": [
-      {
-        "name": "next"
-      }
-    ]
-  },
-  "include": [".", ".next/types/**/*.ts"],
-  "exclude": ["node_modules"]
+    }
+  }
 }

apps/www/package.json

@@ -18,8 +18,8 @@
     "lint": "pnpm run lint:ts ",
     "lint-all": "pnpm run lint:ts && pnpm run lint:md && pnpm run format && pnpm run lint:knip && pnpm run lint:spelling",
     "lint:ts": "tsc --noEmit; eslint .",
-    "lint:knip": "knip --production --strict --exclude exports,nsExports,types,nsTypes",
     "format": "prettier . --write",
+    "lint:knip": "knip --production --strict --exclude exports,nsExports,types,nsTypes",
     "format-check": "prettier --check .",
     "lint:md": "markdownlint \"**/*.md\" --config=.markdownlint.json --ignore-path=.markdownlintignore",
     "lint:spelling": "cspell \"**\" \".github/**/*\"",

apps/www/tsconfig.json

@@ -1,20 +1,9 @@
 {
   "extends": "@ashgw/tsconfig/base.json",
   "compilerOptions": {
-    "lib": ["ES2022", "dom", "dom.iterable"],
-    "jsx": "preserve",
     "baseUrl": ".",
-    "module": "esnext",
-    "target": "ES2022",
     "paths": {
       "~/*": ["./src/*"]
-    },
-    "plugins": [
-      {
-        "name": "next"
-      }
-    ]
-  },
-  "include": [".", ".next/types/**/*.ts"],
-  "exclude": ["node_modules"]
+    }
+  }
 }

packages/env/eslint.config.js

@@ -0,0 +1,9 @@
+import baseConfig from "@ashgw/eslint-config/base";
+
+/** @type {import('typescript-eslint').Config} */
+export default [
+  {
+    ignores: ["dist/**"],
+  },
+  ...baseConfig,
+];

packages/env/index.ts

@@ -1,9 +1,11 @@
+import path from "path";
 import { config } from "dotenv";
 import { z } from "zod";
 
 import { createEnv } from "@ashgw/ts-env";
 
-config({ path: require("path").resolve(__dirname, "../../.env") });
+// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+config({ path: path.resolve(__dirname, "../../.env") });
 
 const isBrowser = typeof window !== "undefined";
 

packages/env/package.json

@@ -3,14 +3,20 @@
   "exports": {
     ".": "./index.ts"
   },
+  "type": "module",
   "private": true,
   "version": "0.1.0",
+  "scripts": {
+    "lint": "tsc --noEmit; eslint .",
+    "format": "prettier . --write"
+  },
   "dependencies": {
     "@ashgw/ts-env": "^1.3.6",
     "zod": "catalog:",
     "dotenv": "^16.4.5"
   },
   "devDependencies": {
+    "@ashgw/eslint-config": "workspace:*",
     "@ashgw/tsconfig": "workspace:*",
     "typescript": "catalog:"
   }

packages/env/tsconfig.json

@@ -1,6 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "compilerOptions": { "lib": ["DOM", "ES2022"] },
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

packages/ui/tsconfig.json

@@ -1,10 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/internal-package.json",
-  "compilerOptions": {
-    "lib": ["ES2022", "dom", "dom.iterable"],
-    "jsx": "preserve",
-    "rootDir": "."
-  },
-  "include": ["src"],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

tooling/eslint/tsconfig.json

@@ -1,5 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

tooling/playwright/base.ts

@@ -1,5 +1,8 @@
 import { defineConfig, devices } from "@playwright/test";
 
+/* eslint-disable turbo/no-undeclared-env-vars */
+const isRunningInCI = !!process.env.CI;
+
 /**
  * Read environment variables from file.
  * https://github.com/motdotla/dotenv
@@ -14,11 +17,11 @@ export const baseConfig = defineConfig({
   /* Run tests in files in parallel */
   fullyParallel: true,
   /* Fail the build on CI if you accidentally left test.only in the source code. */
-  forbidOnly: !!process.env.CI,
+  forbidOnly: isRunningInCI,
   /* Retry on CI only */
-  retries: process.env.CI ? 2 : 0,
+  retries: isRunningInCI ? 2 : 0,
   /* Opt out of parallel tests on CI. */
-  workers: process.env.CI ? 1 : undefined,
+  workers: isRunningInCI ? 1 : undefined,
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: "html",
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */

tooling/playwright/eslint.config.js

@@ -0,0 +1,9 @@
+import baseConfig from "@ashgw/eslint-config/base";
+
+/** @type {import('typescript-eslint').Config} */
+export default [
+  {
+    ignores: ["dist/**"],
+  },
+  ...baseConfig,
+];

tooling/playwright/package.json

@@ -3,11 +3,17 @@
   "exports": {
     ".": "./index.ts"
   },
+  "type": "module",
   "private": true,
   "version": "0.1.0",
+  "scripts": {
+    "lint": "tsc --noEmit; eslint .",
+    "format": "prettier . --write"
+  },
   "devDependencies": {
     "@playwright/test": "catalog:",
     "@ashgw/tsconfig": "workspace:*",
-    "typescript": "catalog:"
+    "typescript": "catalog:",
+    "@ashgw/eslint-config": "workspace:*"
   }
 }

tooling/playwright/tsconfig.json

@@ -1,5 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

tooling/prettier/tsconfig.json

@@ -1,5 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

tooling/tailwind/tsconfig.json

@@ -1,5 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }

tooling/typescript/base.json

@@ -4,8 +4,10 @@
     /** Base Options */
     "esModuleInterop": true,
     "skipLibCheck": true,
+    "jsx": "preserve",
     "target": "ES2022",
-    "lib": ["ES2022"],
+
+    "lib": ["ES2022", "dom", "dom.iterable"],
     "allowJs": true,
     "resolveJsonModule": true,
     "moduleDetection": "force",

tooling/vitest/eslint.config.js

@@ -0,0 +1,9 @@
+import baseConfig from "@ashgw/eslint-config/base";
+
+/** @type {import('typescript-eslint').Config} */
+export default [
+  {
+    ignores: ["dist/**"],
+  },
+  ...baseConfig,
+];

tooling/vitest/package.json

@@ -3,12 +3,18 @@
   "exports": {
     ".": "./index.ts"
   },
+  "type": "module",
   "private": true,
   "version": "0.1.0",
+  "scripts": {
+    "lint": "tsc --noEmit; eslint .",
+    "format": "prettier . --write"
+  },
   "devDependencies": {
     "vitest": "catalog:",
     "@vitest/ui": "catalog:",
     "@ashgw/tsconfig": "workspace:*",
+    "@ashgw/eslint-config": "workspace:*",
     "typescript": "catalog:"
   }
 }

tooling/vitest/tsconfig.json

@@ -1,5 +1,3 @@
 {
-  "extends": "@ashgw/tsconfig/base.json",
-  "include": ["."],
-  "exclude": ["node_modules"]
+  "extends": "@ashgw/tsconfig/base.json"
 }