Update docs around installing packages via git* #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Closing my PR since this was updated also via #157 |
zachallaun
reviewed
Nov 18, 2024
Comment on lines
+315
to
+316
| # adding parts will allow for branch names with forward slashes | ||
| case String.split(requirement, ["/", "@"], trim: true, parts: 3) do |
There was a problem hiding this comment.
Good catch! I'll make sure this is added and tested in the other PR.
|
Thanks for this! I'll make sure the various improvements here are reflected in the other PR as well :) |
I appreciate the review and my test addition. I intended to leave a note if you thought it was worth adding. |
djgoku
deleted the
chore/update-documentation-around-installing-packages-from-git-github
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
One thing I dislike is the test for the
packagemodule, as it involves making a web request.This adds more documentation around this work 0542295 and this issue #84