Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Add included key with resource references in OpenAPI schema #88

Merged
merged 4 commits into from
Aug 5, 2023
Merged

enhancement: Add included key with resource references in OpenAPI schema #88

merged 4 commits into from
Aug 5, 2023

Conversation

skanderm
Copy link
Contributor

@skanderm skanderm commented Aug 5, 2023 •
edited
Loading

The included key that side loads associated records should now include public relationships added in the json_api includes key.

Also adds a fix for the relationships key where the schema was expecting a resource but was getting a Ash.Resource.Relationships.* struct instead.

@zachdaniel zachdaniel merged commit 9586fd3 into ash-project:main Aug 5, 2023
12 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanderm @zachdaniel