improvement: Support generic actions without a return type. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infer that their return type is `:boolean` and they always return `true`. We considered returning `null` but that's also returned when the query/mutation fails and might convey the wrong information.
jimsynz
force-pushed
the
improvement/generic-actions-without-return-type
branch
from
da265fe
to
2d39db5
Compare
|
@sevenseacat relevant to your interests. |
|
This makes the most sense to me. Well |
barnabasJ
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer that their return type is
:booleanand they always returntrue. We considered returningnullbut that's also returned when the query/mutation fails and might convey the wrong information.Contributor checklist