feat: allow providing descriptions for enum values #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbino
force-pushed
the
enum-descriptions
branch
2 times, most recently
from
6dab505
to
a4d0bff
Compare
|
@zachdaniel since you've tagged a new Ash version I've also integrated the new |
Contextually, remove an unreachable clause that caused dyalizer to fail, see ash-project/ash#873 for the commit that made it unreachable
If the module exports `graphql_describe_enum_value/1`, use that. Otherwise, fallback to the Ash.Type.Enum value descriptions introduced in ash-project/ash#940. Close ash-project#116
rbino
force-pushed
the
enum-descriptions
branch
from
a4d0bff
to
a5fdaf1
Compare
|
Removed a clause that cause Dyalizer to fail after the Ash update |
rbino
added a commit
to rbino/edgehog
that referenced
this pull request
Mar 25, 2024
Note that this doesn't expose the capability descriptions yet in the GraphQL schema until ash-project/ash_graphql#117 gets merged Signed-off-by: Riccardo Binetti <[email protected]>
rbino
added a commit
to rbino/edgehog
that referenced
this pull request
Mar 25, 2024
Note that this doesn't expose the capability descriptions yet in the GraphQL schema until ash-project/ash_graphql#117 gets merged Signed-off-by: Riccardo Binetti <[email protected]>
rbino
added a commit
to rbino/edgehog
that referenced
this pull request
Mar 25, 2024
Note that this doesn't expose the capability descriptions yet in the GraphQL schema until ash-project/ash_graphql#117 gets merged Signed-off-by: Riccardo Binetti <[email protected]>
rbino
added a commit
to rbino/edgehog
that referenced
this pull request
Mar 25, 2024
Note that this doesn't expose the capability descriptions yet in the GraphQL schema until ash-project/ash_graphql#117 gets merged. Remove old Absinthe schema and resolvers since they're not needed anymore. Signed-off-by: Riccardo Binetti <[email protected]>
|
🚀 Thank you for your contribution! 🚀 |
smt116
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the module exports
graphql_describe_enum_value/1, use that. Otherwise, fallback to the Ash.Type.Enum value descriptions introduced in ash-project/ash#940.Close #116
Contributor checklist