fix: make results nullable again if root level errors are enabled #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbino
commented
Feb 9, 2024
| @@ -38,7 +36,7 @@ defmodule AshGraphql.ErrorsTest do | |||
|
|
|||
| assert {:ok, result} = resp | |||
|
|
|||
| assert %{data: nil, errors: [%{message: message}]} = result | |||
| assert %{data: %{"createPost" => nil}, errors: [%{message: message}]} = result | |||
There was a problem hiding this comment.
Note that this change returns the behaviour to the one pre #110, so it's not breaking (there was no release between the two)
Building upon ash-project#110, this restores the old behaviour of the result being nullable when root level errors are present. While the result is guaranteed to not be nullable in standard conditions (since either result or errors are always present), when errors are moved to the root level it could become null, so declaring it non-nullable propagates the null up to the data field. This actually causes compatibility problems with some client libraries (e.g. Relay) that expect the inner result to be null, _not_ data, if there's an error. This also adds dedicated RootLevelErrors versions of the Api and the Schema since the configuration is accessed at compile time now, so put_env was not enough to test them correctly.
rbino
force-pushed
the
nullable-result-with-root-level-errors
branch
from
c9d9e48
to
988ba62
Compare
|
🚀 Thank you for your contribution! 🚀 |
rbino
added a commit
to rbino/edgehog
that referenced
this pull request
Feb 9, 2024
Makes results nullable when using root level errors (see ash-project/ash_graphql#114) Signed-off-by: Riccardo Binetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon #110, this restores the old behaviour of the result being nullable when root level errors are present.
While the result is guaranteed to not be nullable in standard conditions (since either result or errors are always present), when errors are moved to the root level it could become null, so declaring it non-nullable propagates the null up to the data field.
This actually causes compatibility problems with some client libraries (e.g. Relay) that expect the inner result to be null, not data, if there's an error.
This also adds dedicated RootLevelErrors versions of the Api and the Schema since the configuration is accessed at compile time now, so put_env was not enough to test them correctly.
Contributor checklist